trunk shadow changes: com.unity.mobile.android-logcat - #215
Open
pets-svc[bot] wants to merge 1 commit into
Open
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
| "System", | ||
| "System.Xml.Linq", | ||
| "UnityEngine.IMGUIModule", | ||
| "UnityEngine.UICommonModule", |
There was a problem hiding this comment.
expectedReferences is an exact list: the loop below requires every entry to occur once. These new compiler-generated dependencies are unconditionally required even though the package is validated on 2021.3 and 2022.3 as well as current 6000/trunk Editors. In the older editor builds where these references are not emitted (the previous list did not contain either), this makes ValidateAssemblyReferences fail with a zero reference count, blocking the existing compatibility CI. Add the dependencies only for the Editor versions that emit them (using the relevant Unity version defines), rather than adding them to the common list.
🤖 Helpful? 👍/👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes made to the
trunkcopy ofcom.unity.mobile.android-logcat.This usually means that breaking changes has landed in the
trunkEditor, necessitating matching changes to your package code.trunkis therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.
Note: The
shadow-package/com.unity.mobile.android-logcatbranch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.